Null comparisons without type-checking operators may not work as intended JS-0059
Bug risk
5 months ago
—
5 months old
Use '===' to compare with null.
258
259
260function doAdjustment(id, title, amount, form, type){
261 if ((id==null) | (id ===""))return;262 db.collection(type).doc(id).set({
263 id: id,
264 title: title,
Description
Comparing to null without a type-checking operator (=== or !==), can have unintended results as the comparison will evaluate to true when comparing to not just a null, but also an undefined value.
Bad Practice
if (flag == null) {
change();
}
while (isSet != null) {
handle();
}
Recommended
if (flag === null) {
change();
}
while (isSet !== null) {
handle();
}