Variable used before definition JS-0129
Bug risk
Major
a year ago
—
a year old
'doAdjustment' was used before it was defined.
246
247})
248document.getElementById('debts_btn').addEventListener(type='click',()=>{
249 doAdjustment(250 document.getElementById('ID_debts').value,
251 document.getElementById('textarea_debts').value,
252 parseInt(document.getElementById('Amount_debts').value),'doAdjustment' was used before it was defined.
237
238})
239document.getElementById('advance_btn').addEventListener(type='click',()=>{
240 doAdjustment(241 document.getElementById('ID_advance').value,
242 document.getElementById('textarea_advance').value,
243 parseInt(document.getElementById('Amount_advance').value),'doAdjustment' was used before it was defined.
219
220})
221document.getElementById('prepayments_btn').addEventListener(type='click',()=>{
222 doAdjustment(223 document.getElementById('ID_prepayment').value,
224 document.getElementById('textarea_prepayment').value,
225 parseInt(document.getElementById('Amount_prepayment').value),'doAdjustment' was used before it was defined.
210}
211
212document.getElementById('accrual_btn').addEventListener(type='click',()=>{
213 doAdjustment(214 document.getElementById('ID_accrual').value,
215 document.getElementById('textarea_accrual').value,
216 parseInt(document.getElementById('Amount_accrual').value),'addRecord' was used before it was defined.
160 colRecords.get().then((querySnapshot) => {
161 querySnapshot.forEach((doc) => {
162 console.log(doc.id, " => ", doc.data());
163 addRecord(164 doc.id,
165 doc.data().dateAndTime,
166 doc.data().assetType,
Description
It is recommended to use a variable only after it is defined as it might produce errors at runtime.
In JavaScript, prior to ES6, variable and function declarations are hoisted to the top of a scope, so it's possible to use identifiers before their formal declarations in code. This can be confusing and some believe it is best to always declare variables and functions before using them.
In ES6, block-level bindings (let and const) introduce a "temporal dead zone" where a ReferenceError will be thrown with any attempt to access the variable before its declaration.
Bad Practice
alert(a);
var a = 10;
f();
function f() {}
function g() {
return b;
}
var b = 1;
{
alert(c);
let c = 1;
}
Recommended
var a;
a = 10;
alert(a);
function f() {}
f(1);
var b = 1;
function g() {
return b;
}
{
let c;
c++;
}