Use
const declarations for variables that are never reassigned JS-0242
Anti-pattern
Minor
2 years ago
—
2 years old
'table' is never reassigned. Use 'const' instead.
192}
193//ela
194function clearTable(name){
195 let table = getElementById(name);196 console.log(table.tBodies.length);
197
198 if(table.tBodies.length>0)'row' is never reassigned. Use 'const' instead.
179
180 let table = getElementById("recordTable");
181
182 let row = table.tBodies[0].insertRow();183
184 row.insertCell().appendChild(document.createTextNode(id.toString()))
185 row.insertCell().appendChild(document.createTextNode(date.toString()))'table' is never reassigned. Use 'const' instead.
177
178function addRecord(id, date, type, status, description, amount){
179
180 let table = getElementById("recordTable");181
182 let row = table.tBodies[0].insertRow();
183'record' is never reassigned. Use 'const' instead.
109document.getElementById('submit').addEventListener("click", () =>{
110 console.log("Submit Clicked");
111
112 let record = {113 dateAndTime: "",
114 assetType: "",
115 creditDebit: "",'reload' is never reassigned. Use 'const' instead.
12const app = firebase.initializeApp(firebaseConfig);
13const db = app.firestore();
14let colRecords = db.collection("records");
15let reload = false; 16
17
18$(document).ready(() => {
Description
Variables that are never re-assigned a new value after their initial declaration should be declared with the const keyword.
This prevents the programmer from erroneously re-assigning to a read-only variable, and informs those reading the code that a variable is a constant value.
Bad Practice
let pi = Math.PI
for (let x of xs) {
use(x);
}
let { a, b } = object;
use(a, b);
Recommended
const pi = Math.PI
for (const x of xs) {
use(x);
}
const { a, b } = object;
use(a, b);