Undefined constants must not be used PHP-W1038
Bug risk
Critical
2 years ago
—
2 years old
Constant None not found
46 echo empty($wp->request) ? "None" : esc_html($wp->request);
47 echo ' -->'.D4P_EOL;
48 echo '<!-- Matched Rewrite Rule: ';
49 echo empty($wp->matched_rule) ? None : esc_html($wp->matched_rule);50 echo ' -->'.D4P_EOL;
51 echo '<!-- Matched Rewrite Query: ';
52 echo empty($wp->matched_query) ? "None" : esc_html($wp->matched_query);
Description
The constant being accessed is not defined, which can result in a runtime warning on PHP < 8.0 and a fatal error on PHP >= 8.0.
Bad practice
$test = SOME_CONSTANT;
// invalid: constant "SOME_CONSTANT" is undefined
echo $test;
Recommended
Either define the constant, or remove the usage if it is not required:
define("SOME_CONSTANT", "Some value");
$test = SOME_CONSTANT;
echo $test;