Bad comparison test PTC-W0023
Anti-pattern
Minor
4 years ago
—
4 years old
Use
is when comparing type of two objects14
15data = pd.read_excel(filename)
16years = data.iloc[3:4, 2:-2]
17year_set = [year for year in list(OrderedDict.fromkeys(years.values[0]).keys()) if type(year) == str]18
19process = data[6:]
20headers = data.iloc[5][2:-2]Use
is when comparing type of two objects 17data = pd.read_excel(filename)
18
19years = data.iloc[2:3, 2:-2]
20year_set = [year for year in list(OrderedDict.fromkeys(years.values[0]).keys()) if type(year) == str] 21process = data[5:]
22headers = data.iloc[4][2:-2]
23header_set = list(OrderedDict.fromkeys(headers.values).keys())
Description
It is recommended to use identity test ( is ) instead of equality test ( == ) when you need to compare types of two objects.
Bad practice
if type(x) == str:
print(x)
Recommended
if type(x) is str:
print(x)
# Alternatively,
if isinstance(x, str):
print(x)