Function contains unused argument PYL-W0613
Anti-pattern
Major
4 years ago
—
4 years old
Unused argument 'max_rows'
19labelIds = main_sections
20
21
22def generate_table(dataframe, max_rows=10):23 data = pd.read_excel('data/2018/aggregates-economic-activity/S7.1.xlsx', header = None)
24 df = data[3:]
25 df.columns = df.iloc[0].fillna(value=pd.Series(range(100)))Unused argument 'dataframe'
19labelIds = main_sections
20
21
22def generate_table(dataframe, max_rows=10):23 data = pd.read_excel('data/2018/aggregates-economic-activity/S7.1.xlsx', header = None)
24 df = data[3:]
25 df.columns = df.iloc[0].fillna(value=pd.Series(range(100)))Unused argument 'dataframe'
20labelIds = [row.iloc[-2] for row in rows[0:-1]]
21
22
23def generate_table(dataframe, max_rows=10): 24 data = pd.read_excel('data/2018/economic-aggregates/S1.7r.xlsx', header = None)
25 df = data[6:]
26 df.columns = df.iloc[0].fillna(value=pd.Series(range(100)))Unused argument 'category'
62
63layout=app_layout()
64
65def filter(year, category, rows, labels, remove=False): 66 cu_index, co_index = [index for index in years.transpose().index if years[index].iloc[0] == year]
67
68 filtered = rows[0:-1] if remove else rowsUnused argument 'max_rows'
20labelIds = [row.iloc[-2] for row in rows[0:-1]]
21
22
23def generate_table(dataframe, max_rows=10): 24 data = pd.read_excel('data/2018/economic-aggregates/S1.7r.xlsx', header = None)
25 df = data[6:]
26 df.columns = df.iloc[0].fillna(value=pd.Series(range(100)))
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42