Unreachable code
56 # submit a empty part without filename
57 if file.filename == "":
58 return "No file selected"
59 return redirect(request.url) 60 if file and allowed_file(file.filename):
61 filename = secure_filename(file.filename)
62 file.save(os.path.join(server.config["UPLOAD_FOLDER"], filename))Unreachable code
50 # check if the post request has the file part
51 if "file" not in request.files:
52 return "No file part"
53 return redirect(request.url) 54 file = request.files["file"]
55 # if user does not select file, browser also
56 # submit a empty part without filename
Description
This statement is unreachable, as the control flow will never reach upto this point. Consider removing this part of code or re-evaluating the control flow.
Bad practice
def count_pairs(users):
pairs = 0
for user in users:
if user.type == "student":
pairs += 1
return pairs
pairs /= 2 # <-- Unreachable
Preferred
def count_pairs(users):
pairs = 0
for user in users:
if user.type == "student":
pairs += 1
pairs /= 2
return pairs