Found the usage of undeclared variables JS-0125
Bug risk
3 months ago
—
3 months old
'ProjectService' is not defined
6 async create(req, res, next) {
7 try {
8 const { projectId } = req.params;
9 const { owner } = await ProjectService.getOne(projectId);10 const submission = await SubmissionService.create({ ...req.body, project: projectId });
11 await UserService.updateQuota(owner, -1);
12 return res.json(submission).status(200);
Description
Variables that aren't defined, but accessed may throw reference errors at runtime.
Potential ReferenceErrors may result from misspellings of variable and parameter names, or accidental implicit globals (for example, forgetting the var keyword in a for loop initializer).
Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment, or specified in the globals key in the configuration file.
A common use case for these is if you intentionally use globals that are defined elsewhere (e.g. in a script sourced from HTML).
Bad Practice
const foo = someFunction();
const bar = a + 1; // 'a' is undeclared
Recommended
/*global someFunction, a*/
/*eslint no-undef: "error"*/
const foo = someFunction();
const bar = a + 1;