Importing the same package multiple times GO-W5021
Anti-pattern
Minor
2 months ago
—
2 years old
package "github.com/prysmaticlabs/prysm/v5/consensus-types/blocks" is being imported more than once
19 "github.com/prysmaticlabs/prysm/v5/beacon-chain/sync/verify"
20 "github.com/prysmaticlabs/prysm/v5/cmd/beacon-chain/flags"
21 "github.com/prysmaticlabs/prysm/v5/config/params"
22 "github.com/prysmaticlabs/prysm/v5/consensus-types/blocks" 23 blocks2 "github.com/prysmaticlabs/prysm/v5/consensus-types/blocks"
24 "github.com/prysmaticlabs/prysm/v5/consensus-types/interfaces"
25 "github.com/prysmaticlabs/prysm/v5/consensus-types/primitives"
Description
Go allows importing the same package multiple times, as long as different import aliases are being used.
However, this is very rarely done on purpose. Usually, it is a sign of code that got refactored, accidentally adding duplicate import statements. It is also a rarely known feature, which may contribute to confusion.
Bad practice
import (
"fmt"
fumpt "fmt"
format "fmt"
_ "fmt"
)
Recommended
import (
"fmt"
)