Redundant error checking RVV-B0005
Style
Major
6 hours ago
—
4 years old
redundant if ...; err != nil check, just return error instead.
361 return err
362 }
363 pbState.Validators = valEntries
364 if err := valIdxBkt.Put(rootHash, validatorKey); err != nil {365 return err
366 }
367 return nilredundant if ...; err != nil check, just return error instead.
343 return err
344 }
345 pbState.Validators = valEntries
346 if err := valIdxBkt.Put(rootHash, validatorKey); err != nil {347 return err
348 }
349 return nilredundant if ...; err != nil check, just return error instead.
325 return err
326 }
327 pbState.Validators = valEntries
328 if err := valIdxBkt.Put(rootHash, validatorKey); err != nil {329 return err
330 }
331 return nilredundant if ...; err != nil check, just return error instead.
307 return err
308 }
309 pbState.Validators = valEntries
310 if err := valIdxBkt.Put(rootHash, validatorKey); err != nil {311 return err
312 }
313 return nilredundant if ...; err != nil check, just return error instead.
289 return err
290 }
291 pbState.Validators = valEntries
292 if err := valIdxBkt.Put(rootHash, validatorKey); err != nil {293 return err
294 }
295 return nil
Description
Some simple error checking patterns can be reduced to just a single return
statement returning a variable of type Error.
Bad practice
if err != nil {
return err
}
return nil
Recommended
return err