Use
(*bytes.Buffer).String or (*bytes.Buffer).Bytes SCC-S1030
Anti-pattern
Major
2 months ago
—
2 months old
should use wr.Body.String() instead of string(wr.Body.Bytes())
244 s.GetValidators(wr, req)
245 require.Equal(t, tt.wantCode, wr.Code)
246 if tt.wantErr != "" {
247 require.StringContains(t, tt.wantErr, string(wr.Body.Bytes()))248 } else {
249 resp := &ValidatorsResponse{}
250 require.NoError(t, json.Unmarshal(wr.Body.Bytes(), resp))
Description
(*bytes.Buffer) has both - a String and a Bytes method. It is unnecessary
to use string(buf.Bytes()) or []byte(buf.String()).
Bad practice
string(buf.Bytes())
[]byte(buf.String())
Recommended
buf.String()
buf.Bytes()