Incorrectly formatted error string SCC-ST1005
Style
Minor
25 days ago
—
4 years old
error strings should not be capitalized
258 if err != nil {
259 return errors.Wrap(err, "failed to marshal Lighthouse response to JSON")
260 }
261 return fmt.Errorf("Prysm response %s does not match Lighthouse response %s", string(p), string(lh))262 }
263 return nil
264}error strings should not be capitalized
172 }
173 directAddrInfos, err := peer.AddrInfosFromP2pAddrs(addrs...)
174 if err != nil {
175 return nil, fmt.Errorf("Cannot convert peers multiaddresses into AddrInfos: %v", err)176 }
177 return directAddrInfos, nil
178}error strings should not be capitalized
168 return nil, fmt.Errorf("Cannot convert peers raw ENRs into multiaddresses: %v", err)
169 }
170 if len(addrs) == 0 {
171 return nil, fmt.Errorf("Converting peers raw ENRs into multiaddresses resulted in an empty list")172 }
173 directAddrInfos, err := peer.AddrInfosFromP2pAddrs(addrs...)
174 if err != nil {error strings should not be capitalized
165func parsePeersEnr(peers []string) ([]peer.AddrInfo, error) {
166 addrs, err := PeersFromStringAddrs(peers)
167 if err != nil {
168 return nil, fmt.Errorf("Cannot convert peers raw ENRs into multiaddresses: %v", err)169 }
170 if len(addrs) == 0 {
171 return nil, fmt.Errorf("Converting peers raw ENRs into multiaddresses resulted in an empty list")
Description
Error strings follow a set of guidelines to ensure uniformity and good composability.
Quoting Go Code Review Comments:
Error strings should not be capitalized (unless beginning with
proper nouns or acronyms) or end with punctuation, since they are
usually printed following other context. That is, use
fmt.Errorf("something bad") not fmt.Errorf("Something bad"), so
that log.Printf("Reading %s: %v", filename, err) formats without a
spurious capital letter mid-message.