append result not assigned to the same slice
121 // Mix in current epoch
122 b := make([]byte, 8)
123 binary.LittleEndian.PutUint64(b, uint64(currentEpoch))
124 key := append(r, b...)125
126 // Mix in validator count
127 b = make([]byte, 8)
Description
The builtin function append returns the updated slice after the append operation.
This resulting slice is usually assigned back to the same variable that contained
the original slice to which new values were appended.
Bad practice
x = []int{1, 3, 5}
append(x, 7) // returns the value []int{1, 3, 5, 7}. This is usually assigned back to x
x := []int{}
y := []int{}
x = append(y, 1) // possibly wrong
Recommended
x = []int{1, 3, 5}
x = append(x, 7)
x := []int{}
y := []int{}
y = append(y, 1) // append 1 to y