this value of unlock is never used
56 {Slot: 4, ValidatorIndex: 1, Signature: []byte{'h'}},
57 }, msgs)
58
59 msgs, unlock, err = store.SyncCommitteeMessages(5) 60 require.NoError(t, err)
61 require.DeepSSZEqual(t, []*ethpb.SyncCommitteeMessage{
62 {Slot: 5, ValidatorIndex: 0, Signature: []byte{'i'}},this value of unlock is never used
49 {Slot: 3, ValidatorIndex: 1, Signature: []byte{'f'}},
50 }, msgs)
51
52 msgs, unlock, err = store.SyncCommitteeMessages(4) 53 require.NoError(t, err)
54 require.DeepSSZEqual(t, []*ethpb.SyncCommitteeMessage{
55 {Slot: 4, ValidatorIndex: 0, Signature: []byte{'g'}},this value of unlock is never used
42 require.NoError(t, err)
43 require.DeepSSZEqual(t, []*ethpb.SyncCommitteeMessage(nil), msgs)
44
45 msgs, unlock, err = store.SyncCommitteeMessages(3) 46 require.NoError(t, err)
47 require.DeepSSZEqual(t, []*ethpb.SyncCommitteeMessage{
48 {Slot: 3, ValidatorIndex: 0, Signature: []byte{'e'}},this value of unlock is never used
38 require.NoError(t, err)
39 require.DeepSSZEqual(t, []*ethpb.SyncCommitteeMessage(nil), msgs)
40
41 msgs, unlock, err = store.SyncCommitteeMessages(2) 42 require.NoError(t, err)
43 require.DeepSSZEqual(t, []*ethpb.SyncCommitteeMessage(nil), msgs)
44this value of unlock is never used
34 require.NoError(t, store.SaveSyncCommitteeMessage(msg))
35 }
36
37 msgs, unlock, err := store.SyncCommitteeMessages(1) 38 require.NoError(t, err)
39 require.DeepSSZEqual(t, []*ethpb.SyncCommitteeMessage(nil), msgs)
40
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}