can replace 'else {if cond {}}' with 'else if cond {}'
214 return nil, false, errors.New("underflow: zero validators")
215 }
216 index = primitives.ValidatorIndex(numVals - 1)
217 } else {218 if !isElectraOrLater {
219 if err := helpers.IncreaseBalance(beaconState, index, amount); err != nil {
220 return nil, newValidator, err
Description
A single nested if inside an else block can be replaced with an else if.
It's better to have as little nesting as possible. Hence, it's cleaner to
replace a single nested if inside an else with an else-if.
Bad practice
if cond1 {
// do something
} else {
if x := cond2; x {
// do something else
}
}
Recommended
if cond1 {
// do something
} else if x := cond2; x {
// do something else
}