JS-0002 @ 43795de • pumpkin-zbh / amqp_comm

Run summary

a year ago

631cdd7..43795de

10 s

Avoid using console in code that runs on browser JS-0002

Bug risk

Major

6 occurrences in this check

Avoid using console in code that runs on the browser

src/gateway.js

 80        }
 81    }
 82    console.log("===Report Scan Data\n topic=" + topic)
 83    console.log(payloadJson) 84    return JSON.stringify(payloadJson);
 85}
 86

Avoid using console in code that runs on the browser

src/gateway.js

 29const subTopic = `/${deviceConfig.productKey}/${deviceConfig.deviceName}/user/get`;
 30client.subscribe(subTopic)
 31client.on('message', function(topic, message) {
 32    console.log("topic " + topic) 33    console.log("message " + message)
 34})
 35

Avoid using console in code that runs on the browser

src/gateway.js

 30client.subscribe(subTopic)
 31client.on('message', function(topic, message) {
 32    console.log("topic " + topic)
 33    console.log("message " + message) 34})
 35
 36//IoT平台mqtt连接参数初始化

Avoid using console in code that runs on the browser

src/gateway.js

 79            }
 80        }
 81    }
 82    console.log("===Report Scan Data\n topic=" + topic) 83    console.log(payloadJson)
 84    return JSON.stringify(payloadJson);
 85}

Avoid using console in code that runs on the browser

src/client.js

116        const sn = ALIYUN.DEVICE_NAME;
117        let rawdata = fs.readFileSync(jsonFile);
118        let person = JSON.parse(rawdata);
119        console.log(person.START_JUMP)120        let client = Client.createClient(ALIYUN.ACCESS_KEY, ALIYUN.ACCESS_KEY_SECRET);
121        await Client.BatchPubSample(client, ALIYUN.PRODUCT_KEY, ALIYUN.IOT_INSTANCE_ID, base64encode(JSON.stringify(person.START_JUMP)), topic, sn);
122    }

Avoid using console in code that runs on the browser

src/client.js

105        const sn = ALIYUN.DEVICE_NAME;
106        let rawdata = fs.readFileSync(jsonFile);
107        let person = JSON.parse(rawdata);
108        console.log(person.GROUPING)109        let client = Client.createClient(ALIYUN.ACCESS_KEY, ALIYUN.ACCESS_KEY_SECRET);
110        await Client.BatchPubSample(client, ALIYUN.PRODUCT_KEY, ALIYUN.IOT_INSTANCE_ID, base64encode(JSON.stringify(person.GROUPING)), topic, sn);
111    }

Description

It is considered a best practice to avoid the use of any console methods in JavaScript code that will run on the browser.

NOTE: If your repository contains a server side project, you can add "nodejs" to the environment property of analyzer meta in .deepsource.toml. This will prevent this issue from getting raised. Documentation for the analyzer meta can be found here. Alternatively, you can silence this issue for your repository as shown here.

If a specific console call is meant to stay for other reasons, you can add a skipcq comment to that line. This will inform other developers about the reason behind the log's presence, and prevent DeepSource from flagging it.

Usually, console methods are only used for debugging, and can leak internal info to the client. Removing the console call will fix this issue.

Bad Practice

if (!secure(data)) {
  console.log("data is not secure", data) // `data` is visible to the client
}

console.table(tableObj)

pumpkin-zbh / amqp_comm_example

Bad Practice

Recommended