Unnecessary use of comprehension PYL-R1721
Performance
Major
2 years ago
—
2 years old
Unnecessary use of a comprehension, use list(range(TEST_DATA_SET_COUNT)) instead.
131 eval(f"quantum_circuit.increment_step().{gate}.{gate}")
132
133
134TWO_QBIT_GATES = two_qbit_gates([x for x in range(TEST_DATA_SET_COUNT)], [x + 1 for x in range(TEST_DATA_SET_COUNT)])135
136
137@pytest.mark.parametrize("gate", TWO_QBIT_GATES)Unnecessary use of a comprehension, use list(range(TEST_DATA_SET_COUNT)) instead.
141 eval(f"quantum_circuit.increment_step().{gate}.{gate}")
142
143
144TWO_QBIT_GATES = two_qbit_gates([x for x in range(TEST_DATA_SET_COUNT)], [x for x in range(TEST_DATA_SET_COUNT)])145
146
147@pytest.mark.parametrize("gate", TWO_QBIT_GATES)Unnecessary use of a comprehension, use list(range(TEST_DATA_SET_COUNT)) instead.
121 ]
122
123
124SINGLE_QBIT_GATES = single_qbit_gates([x for x in range(TEST_DATA_SET_COUNT)])125
126
127@pytest.mark.parametrize("gate", SINGLE_QBIT_GATES)Unnecessary use of a comprehension, use list(range(TEST_DATA_SET_COUNT)) instead.
151 eval(f"quantum_circuit.increment_step().{gate}")
152
153
154SINGLE_QBIT_GATES = single_qbit_gates([x for x in range(TEST_DATA_SET_COUNT)])155TWO_QBIT_GATES = two_qbit_gates([x for x in range(TEST_DATA_SET_COUNT)], [x + TEST_DATA_SET_COUNT for x in range(TEST_DATA_SET_COUNT)])
156GATES = [(SINGLE_QBIT_GATES[i], TWO_QBIT_GATES[i]) for i in range(TEST_DATA_SET_COUNT)]
157Unnecessary use of a comprehension, use list(range(TEST_DATA_SET_COUNT)) instead.
152
153
154SINGLE_QBIT_GATES = single_qbit_gates([x for x in range(TEST_DATA_SET_COUNT)])
155TWO_QBIT_GATES = two_qbit_gates([x for x in range(TEST_DATA_SET_COUNT)], [x + TEST_DATA_SET_COUNT for x in range(TEST_DATA_SET_COUNT)])156GATES = [(SINGLE_QBIT_GATES[i], TWO_QBIT_GATES[i]) for i in range(TEST_DATA_SET_COUNT)]
157
158
Description
It is unnecessary to use a comprehension just to loop over the iterable and create a list/set/dict out of it.
Python has a specialized set of tools for this task: the list/set/dict constructors, which are faster and more readable.
Bad practice
states = [
('AL', 'Alabama'),
('AK', 'Alaska'),
('AZ', 'Arizona'),
('AR', 'Arkansas'),
('CA', 'California'),
# ...
]
abbreviations_to_names = {
abbreviation: name
for abbreviation, name in states
}
Recommended
states = [
('AL', 'Alabama'),
('AK', 'Alaska'),
('AZ', 'Arizona'),
('AR', 'Arkansas'),
('CA', 'California'),
# ...
]
abbreviations_to_names = dict(states)