Errors should not be suppressed
356
357 private function createTransaction($payload)
358 {
359 $customArray = @unserialize(base64_decode((string)$payload['client_reference_id']));360 $customArray = $customArray && is_array($customArray) ? $customArray : array();
361 $customData = new Flux_Config($customArray);
362 $accountID = $customData->get('account_id');Errors should not be suppressed
101 $this->myCurrencyCode = strtoupper(Flux::config('DonationCurrency'));
102 $this->webhookSecret = Flux::config('StripeWebhookSecret');
103 $this->sigHeader = $_SERVER['HTTP_STRIPE_SIGNATURE'];
104 $this->payload = @file_get_contents("php://input");105 }
106
107 /**Errors should not be suppressed
404 $this->logPayPal('Query string: %s', $qString);
405 $this->logPayPal('Establishing connection to PayPal server at %s:443...', $this->ppServer);
406
407 $fp = @fsockopen('ssl://'.$this->ppServer, 443, $errno, $errstr, 20);408 if (!$fp) {
409 $this->logPayPal("Failed to connect to PayPal server: [%d] %s", $errno, $errstr);
410 return false;Errors should not be suppressed
325 if(!in_array($received_from, $allowed_hosts) && Flux::config('PaypalHackNotify')){
326 require_once 'Flux/Mailer.php';
327
328 $customArray = @unserialize(base64_decode((string)$this->ipnVariables->get('custom')));329 $customArray = $customArray && is_array($customArray) ? $customArray : array();
330 $customData = new Flux_Config($customArray);
331 $accountID = $customData->get('account_id');Errors should not be suppressed
155 $this->logPayPal('Receiver e-mail (%s) is not recognized, unauthorized to continue.', $receiverEmail);
156 }
157 else {
158 $customArray = @unserialize(base64_decode((string)$this->ipnVariables->get('custom')));159 $customArray = $customArray && is_array($customArray) ? $customArray : array();
160 $customData = new Flux_Config($customArray);
161 $accountID = $customData->get('account_id');
Description
Suppressing errors using an error control operator(@) is discouraged. Instead of ignoring the raised error, it should be fixed accordingly.
Bad practice
$user = ['name' => 'John', 'age' => 23];
echo @$user['city'];
Recommended
$user = ['name' => 'John', 'age' => 23];
if (isset($user['city'])) {
echo $user['city'];
}