Unused argument 'n'
72 deinterlaced_tff = kernel(self.clip, TFF=True)
73 deinterlaced_bff = kernel(self.clip, TFF=False)
74
75 def _d(n: int, f: vs.VideoFrame, c: vs.VideoNode, tff: vs.VideoNode, bff: vs.VideoNode): 76 # deinterlace if _FieldBased > 0
77 rc = {0: c, 1: bff, 2: tff}[f.props["_FieldBased"]] # type: ignore
78 return core.text.Text(
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _
or start the name with unused
or _unused
.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42