PYL-W0612 · Unused variable found

rohit-clootrack / linting-test

Active

Unused variable found PYL-W0612

Anti-pattern

Major

a year ago — a year old

Unused variable 'site'

linting_test/contrib/sites/migrations/0003_set_site_domain_and_name.py

 9
10def _update_or_create_site_with_sequence(site_model, connection, domain, name):
11    """Update or create the site with default ID and keep the DB sequence in sync."""
12    site, created = site_model.objects.update_or_create(13        id=settings.SITE_ID,
14        defaults={
15            "domain": domain,

Description

An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.

Bad practice

def update():
    for i in range(10): # Usused variable `i`
        time.sleep(0.01)
        display_result()

Preferred:

def update():
    for _ in range(10):
        time.sleep(0.01)
        display_result()