Value assigned to a variable is never read before being overwritten SCC-SA4006
Bug risk
9 months ago
—
a year old
this value of err is never used
209 logrus.Errorf("hours %f\n", h)
210 }
211
212 subAccount, err := GetSubAccountByID(e, "")213
214 qtyUSD, err := strconv.ParseFloat(chi.URLParam(request, "qty"), 64)
215 if err != nil {this value of err is never used
123 UseOrderType(orderType).
124 SetSide(side)
125
126 newOrder, err := ob.Build()127
128 logrus.Printf("new order: %+v\n", newOrder)
129this value of err is never used
46 logrus.Errorf("Error getting holdings: %s\n", err)
47 }
48
49 subAccount, err := subaccount.GetByID(e, "")50
51 response, err := holdings.CurrencyBalance(subAccount.ID, asset.Spot, code)
52 if err != nil {this value of err is never used
84
85 subAccount, err := GetSubAccountByID(e, "")
86
87 depositRequest.Chains, err = e.GetAvailableTransferChains(context.Background(), depositRequest.Code) 88 logrus.Info(depositRequest.Chains)
89 depositRequest.Asset = depositRequest.Code.Item
90 depositRequest.AccountID = subAccount.IDthis value of err is never used
82 // logrus.Printf("%s\n", p.Base.String())
83 //}
84
85 subAccount, err := GetSubAccountByID(e, "") 86
87 depositRequest.Chains, err = e.GetAvailableTransferChains(context.Background(), depositRequest.Code)
88 logrus.Info(depositRequest.Chains)
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}