Detected unnecessary constructors JS-0358
Anti-pattern
Minor
2 years ago
—
2 years old
Useless constructor
10export class BlogComponent extends PageComponent {
11 routestring = '/blog';
12
13 constructor(location: Location, menuService: MenuService) {14 super(location, menuService);15 }16}
Useless constructor
15 public website: string = person.website;
16 routestring = '/profile';
17
18 constructor(location: Location, menuService: MenuService) {19 super(location, menuService);2021 }22}
Useless constructor
10export class ResumeComponent extends PageComponent {
11 routestring = '/resume';
12
13 constructor(location: Location, menuService: MenuService) {14 super(location, menuService);15 }16}
Useless constructor
14 public locationString: string = person.location;
15 public website: string = person.website;
16
17 constructor(location: Location, menuService: MenuService) {18 super(location, menuService);19 }20}
Useless constructor
58 bootstrap: [AppComponent],
59})
60export class AppModule {
61 constructor() {62 // Add an icon to the library for convenient access in other components63 // library.add(faCoffee);64 }65}
Description
ES2015 provides a default class constructor if one isn't explicitly specified. As such, it is unnecessary to provide an empty constructor or one that simply delegates into its parent class.
Bad Practice
class Animal {
constructor () {}
}
class Dog extends Animal {
constructor() { super() }
bark() { /* code */ }
}
Recommended
class Animal {}; // empty abstract class
class Dog extends Animal {
bark() { /* code */ }
};