Undefined properties must not be accessed PHP-W1033
Bug risk
Major
5 months ago
—
a year old
Access to an undefined property App\User::$api_token
22
23 public function creating(User $user)
24 {
25 $user->api_token = bin2hex(openssl_random_pseudo_bytes(30));26 }
27
28 /**Access to an undefined property App\User::$avatar
81 $featuredAvatar,
82 $filename
83 );
84 $user->avatar = url('/').'/images/'.$filename; 85 }
86
87 $user->save();Access to an undefined property App\User::$name
69 $user = User::find($id);
70
71 if($request->has('name')){
72 $user->name = $request->get('name'); 73
74 }
75Access to an undefined property App\User::$password
42 $user = new User();
43 $user->name = $request->get('name');
44 $user->email = $request->get('email');
45 $user->password = Hash::make($request->get('password')); 46 $user->save();
47
48 return new UserResource($user);Access to an undefined property App\User::$email
41
42 $user = new User();
43 $user->name = $request->get('name');
44 $user->email = $request->get('email'); 45 $user->password = Hash::make($request->get('password'));
46 $user->save();
47
Description
This issue is raised when an attempt is made to access an undefined property. This may not have been intended, and it is advisable to give the code another look to make sure the property is defined in the scope it is used in.
Bad practice
class User
{
private string $firstName = 'John';
public function getFirstName(): void
{
return $this->firstName;
}
public function getLastName(): void
{
return $this->lastName; // invalid: property "lastName" is not defined
}
}
Recommended
class User
{
private string $firstName = 'John';
private string $lastName = 'Doe';
public function getFirstName(): void
{
return $this->firstName;
}
public function getLastName(): void
{
return $this->lastName;
}
}