Errors detected in .deepsource.toml.
Exception caught is very general PYL-W0703
Anti-pattern
Major
3 years ago
—
3 years old
Catching too general exception Exception
139 def __del__(self):
140 try:
141 shutil.rmtree(self.tempdir)
142 except Exception:143 returnCatching too general exception Exception
82 dex = self.tempdir + "/" + self.apk.package + ".dex"
83 with open(dex, "wb") as classes:
84 classes.write(zipped.read("classes.dex"))
85 except Exception as e: 86 sys.exit(self.writeln(str(e), clr.WARNING))
87 dec = "%s %s -d %s --deobf" % (self.jadx, dex, self.tempdir)
88 os.system(dec)Catching too general exception Exception
68 if os.path.isfile(self.file) is True:
69 try:
70 self.apk = self.apk_info()
71 except Exception as e: 72 sys.exit(self.writeln(str(e), clr.WARNING))
73 else:
74 return self.apk
Description
If the except block catches a very general exception, it is likely to catch any unrelated errors too. Try to be more explicit about which exception(s) you're trying to catch.
If you need to catch every other exception, then mark it as intentional by
adding a # skipcq comment.
Bad practice
try:
x = a / b
except Exception:
x = a / (b + 1)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except BaseException:
print('Only use numbers for the input')
Preferred:
try:
x = a / b
except ZeroDivisionError:
x = a / (b + 1)
try:
event_loop.run()
except Exception as exc: # skipcq: PYL-W0703 - Loop can sometimes crash.
sentry.report(exc)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except ValueError:
print('Only use numbers for the input')