Starting a process with a shell, possible injection detected, security issue.
85 except Exception as e:
86 sys.exit(self.writeln(str(e), clr.WARNING))
87 dec = "%s %s -d %s --deobf" % (self.jadx, dex, self.tempdir)
88 os.system(dec) 89 return self.tempdir
90
91 def unique(self, list):
Description
Spawning of a subprocess using a command shell is dangerous as it is vulnerable to various shell injection attacks. Great care should be taken to sanitize all input in order to mitigate this risk. Calls of this type are identified by the use of certain commands which are known to use shells.
It is possible for an attacker to craft inputs to issue different commands than the ones you intended such as removing a file.
It is recommended to use functions that don't spawn a shell. If you must use them, use shlex.quote to sanitize the input by changing it to the shell-escaped version.
Bad practice
import os
# Malicious input
filename = "file.py; echo foo"
# Executing command in a shell without escaping. This will also run `echo foo`.
os.system("git add " + filename)
Recommended
import os, shlex
# Malicious input
filename = "file.py; echo foo"
# This ensures someone can't inject other commands into the given command.
os.system("git add " + shlex.quote(filename))
References:
- Command Injection
- shlex
- OWASP Top 10 2021 Category A03 - Injection
- SANS Top 25
- CWE-78