Consider using dot notation JS-0303
Anti-pattern
Minor
5 months ago
—
5 months old
["text"] is better written in dot notation
126 assert.ok(Object.prototype.hasOwnProperty.call(msg, "file"));
127
128 assert.strictEqual(msg["file"], tmpFile);
129 assert.strictEqual(msg["text"], "print");130 }
131 });
132});["file"] is better written in dot notation
125 assert.ok(Object.prototype.hasOwnProperty.call(msg, "text"));
126 assert.ok(Object.prototype.hasOwnProperty.call(msg, "file"));
127
128 assert.strictEqual(msg["file"], tmpFile);129 assert.strictEqual(msg["text"], "print");
130 }
131 });["text"] is better written in dot notation
108
109 assert.strictEqual(msg["file"], tmpFile);
110 assert.strictEqual(msg["text"], "print('hello world')");
111 assert.strictEqual(msg["text"], editor.document.getText());112 }
113 });
114["text"] is better written in dot notation
107 assert.ok(Object.prototype.hasOwnProperty.call(msg, "file"));
108
109 assert.strictEqual(msg["file"], tmpFile);
110 assert.strictEqual(msg["text"], "print('hello world')");111 assert.strictEqual(msg["text"], editor.document.getText());
112 }
113 });["file"] is better written in dot notation
106 assert.ok(Object.prototype.hasOwnProperty.call(msg, "text"));
107 assert.ok(Object.prototype.hasOwnProperty.call(msg, "file"));
108
109 assert.strictEqual(msg["file"], tmpFile);110 assert.strictEqual(msg["text"], "print('hello world')");
111 assert.strictEqual(msg["text"], editor.document.getText());
112 }
Description
In TypeScript, one can access properties using the dot notation (object.property) or square-bracket notation (object["property"]). However, the dot notation is often preferred because it is easier to read and less verbose.
Dot Notation In the
object.propertysyntax, the property must be a valid JavaScript identifier. (In the ECMAScript standard, the names of properties are technically "IdentifierNames", not "Identifiers", so reserved words can be used but are not recommended). For example,object.$1is valid, whileobject.1is not.Bracket Notation In the
object[property_name]syntax, theproperty_nameis just astringorSymbol. So, it can be any string, including1hello,!world!, or even(a space).
Bad Practice
object["property"];
Recommended
object.property