JS-0333 · Detected usage of void type outside of generic or return types

Detected usage of void type outside of generic or return types JS-0333

Anti-pattern

Minor

5 months ago — 5 months old

void is not valid as a constituent in a union type

183export class NukeNodesInspectorProvider implements vscode.TreeDataProvider<Dependency> {
184    private _onDidChangeTreeData: vscode.EventEmitter<Dependency | undefined | null | void> =
185        new vscode.EventEmitter<Dependency | undefined | null | void>();
186    readonly onDidChangeTreeData: vscode.Event<Dependency | undefined | null | void> =187        this._onDidChangeTreeData.event;
188
189    /**

void is not valid as a constituent in a union type

src/nuke/nodes_tree.ts

182
183export class NukeNodesInspectorProvider implements vscode.TreeDataProvider<Dependency> {
184    private _onDidChangeTreeData: vscode.EventEmitter<Dependency | undefined | null | void> =
185        new vscode.EventEmitter<Dependency | undefined | null | void>();186    readonly onDidChangeTreeData: vscode.Event<Dependency | undefined | null | void> =
187        this._onDidChangeTreeData.event;
188

void is not valid as a constituent in a union type

src/nuke/nodes_tree.ts

181}
182
183export class NukeNodesInspectorProvider implements vscode.TreeDataProvider<Dependency> {
184    private _onDidChangeTreeData: vscode.EventEmitter<Dependency | undefined | null | void> =185        new vscode.EventEmitter<Dependency | undefined | null | void>();
186    readonly onDidChangeTreeData: vscode.Event<Dependency | undefined | null | void> =
187        this._onDidChangeTreeData.event;

Description

Disallows usage of void type outside of return types or generic type arguments. If void is used as return type, it shouldn’t be a part of intersection/union type with most other types.

Bad Practice

type PossibleValues = string | number | void;
type MorePossibleValues = string | ((number & any) | (string | void));

function logSomething(thing: void) {}
function printArg<T = void>(arg: T) {}

logAndReturn<void>(undefined);

interface Interface {
  lambda: () => void;
  prop: void;
}

class MyClass {
  private readonly propName: void;
}

sisoe24 / Nuke-Tools

Bad Practice

Recommended