Found unused variables in TypeScript code JS-0356
Performance
Major
5 months ago
—
3 years old
'context' is defined but never used
11 document: vscode.TextDocument,
12 position: vscode.Position,
13 token: vscode.CancellationToken,
14 context: vscode.CompletionContext15 ): vscode.ProviderResult<
16 vscode.CompletionItem[] | vscode.CompletionList<vscode.CompletionItem>
17 > {'token' is defined but never used
10 provideCompletionItems(
11 document: vscode.TextDocument,
12 position: vscode.Position,
13 token: vscode.CancellationToken,14 context: vscode.CompletionContext
15 ): vscode.ProviderResult<
16 vscode.CompletionItem[] | vscode.CompletionList<vscode.CompletionItem>
Description
Unused variables are generally considered a code smell and should be avoided.
Removing unused references - It prevents unused modules from being loaded at runtime, improving performance, and preventing the compiler from loading metadata that will never be used. - It prevents conflicts that may occur when trying to reference another variable.
NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _ to prevent them from being flagged by DeepSource.
Bad Practice
import fs from 'fs' // <- unused
import { readFileSync } from 'fs'
const text = readFileSync('declaration_of_independence.txt', 'utf-8')
console.log(text)
Recommended
import { readFileSync } from 'fs'
const text = readFileSync('declaration_of_independence.txt', 'utf-8')
console.log(text)