Found redundant literal in a logical expression JS-W1043
Anti-pattern
Minor
5 months ago
—
5 months old
Logical expression with a literal operand will always evaluate to the same value
44 const projectPySide = (await vscode.window.showInputBox({
45 title: "PySide2 Version",
46 placeHolder: "Version of PySide2",
47 value: (getConfig("pysideTemplate.pysideVersion") as string) || "5.12.2", 48 })) as string;
49
50 const projectAuthor = (await vscode.window.showInputBox({Logical expression with a literal operand will always evaluate to the same value
38
39 const projectPython = (await vscode.window.showInputBox({
40 title: "Python version",
41 value: (getConfig("pysideTemplate.pythonVersion") as string) || "~3.7.7", 42 })) as string;
43
44 const projectPySide = (await vscode.window.showInputBox({
Description
Expressions that consistently result in either true or false when comparing values, and logical operations like ||, &&, and ?? that consistently either skip or fully evaluate their operands, often indicate mistakes. Logical operations that always yield the same result could lead to unexpected behavior or bugs in the program.
Bad Practice
const arrIsEmpty = someArr === [] // Will always evaluate to false
Recommended
const arrIsEmpty = someArr.length === 0