Unexpected 'todo' comment: 'TODO: how to be sure that connection is...'
82 });
83
84 test("sendMessage no connection", async () => {
85 // TODO: how to be sure that connection is closed86
87 const received = await socket.sendMessage();
88 if (received) {
Unexpected 'todo' comment: 'TODO: how to be sure that connection is...'
65 });
66
67 test("sendDebugMessage", async () => {
68 // TODO: how to be sure that connection is closed69 const received = await socket.sendDebugMessage();
70 assert.strictEqual(received.error, true);
71 assert.strictEqual(received.message, "Connection refused");
Unexpected 'xxx' comment: 'XXX: check why NukeServerSocket...'
49
50 test("Change network address when enableConnection is true", async () => {
51 // TODO: should call Promise.all. but it doesn't work
52 // XXX: check why NukeServerSocket workspace had this settings. 53 await utils.updateConfig("network.enableManualConnection", true);
54 await utils.updateConfig("network.host", "192.186.1.00");
55 await utils.updateConfig("network.port", "55555");
Unexpected 'todo' comment: 'TODO: should call Promise.all. but it...'
48 });
49
50 test("Change network address when enableConnection is true", async () => {
51 // TODO: should call Promise.all. but it doesn't work 52 // XXX: check why NukeServerSocket workspace had this settings.
53 await utils.updateConfig("network.enableManualConnection", true);
54 await utils.updateConfig("network.host", "192.186.1.00");
Unexpected 'todo' comment: 'TODO: should call Promise.all. but it...'
38 });
39
40 test("Changing network addresses should not work if enableConnection is false", async () => {
41 // TODO: should call Promise.all. but it doesn't work 42 await utils.updateConfig("network.enableManualConnection", false);
43 await utils.updateConfig("network.host", "192.136.1.99");
44 await utils.updateConfig("network.port", "99999");
Unexpected 'todo' comment: 'TODO: should call Promise.all. but it...'
29 });
30
31 test("Get manual address but no address is saved", async () => {
32 // TODO: should call Promise.all. but it doesn't work 33 await utils.updateConfig("network.enableManualConnection", true);
34 await utils.updateConfig("network.host", "");
35
Unexpected 'todo' comment: 'TODO: should call Promise.all. but it...'
20 });
21
22 test("Get manual address", async () => {
23 // TODO: should call Promise.all. but it doesn't work 24 await utils.updateConfig("network.enableManualConnection", true);
25 await utils.updateConfig("network.host", "localhost");
26
Unexpected 'todo' comment: 'TODO: currently don't know how to grab...'
149 assert.ok(match);
150 });
151
152 // TODO: currently don't know how to grab this info153 test.skip("Check if terminal has cmd line text");
154 test.skip("Check if terminal is shown");
155
Unexpected 'xxx' comment: 'XXX: this will sto test execution...'
106 });
107
108 test.skip("Primary executable with prompt arguments", async () => {
109 // XXX: this will sto test execution waiting for user input110 await utils.updateConfig("nukeExecutable.primaryExecutablePath", samplePath);
111
112 const execPath = await executables.launchPromptExecutable();
Unexpected 'todo' comment: 'TODO: can monkeypatch the os module?'
22 });
23
24 test.skip("Check path if on Windows", () => {
25 // TODO: can monkeypatch the os module? 26 it("should insert he & operator if on Windows system");
27 });
28
Unexpected 'xxx' comment: 'XXX: coverage doesn't seem to update...'
57 // Debug which files will be included/excluded
58 // console.log('Glob verification', await nyc.exclude.glob(nyc.cwd));
59
60 // XXX: coverage doesn't seem to update each run so I am deleting the folder61 rmdirSync(path.join(nyc.cwd, nyc._tempDirectory), { recursive: true });
62
63 await nyc.createTempDirectory();
Unexpected 'todo' comment: 'TODO: send all the code at once and then...'
204 const files = osWalk(KNOBS_DIR);
205 const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
206
207 // TODO: send all the code at once and then rename the files. 208
209 for (let i = 0; i < files.length; i++) {
210 const file = files[i];
Unexpected 'todo' comment: 'TODO: add command only to knobs'
170 this.description = this.version;
171 this.contextValue = context.context;
172
173 // TODO: add command only to knobs174 this.command = {
175 command: "nuke-tools.on_itemClicked",
176 title: label,
Unexpected 'todo' comment: 'TODO: add windows support.'
159export function getCliCmd(execPath: ExecutablePath): string {
160 const cliCmd = execPath.cliCmd();
161
162 // TODO: add windows support.163 if (os.type() === "Windows_NT") {
164 return cliCmd;
165 }
Unexpected 'xxx' comment: 'XXX: how to force closing connection?'
153
154// this method is called when your extension is deactivated
155export function deactivate(): void {
156 // XXX: how to force closing connection?157}
Unexpected 'todo' comment: 'TODO: Get latest version from github api'
14 vimdcc = "vimdcc",
15}
16
17// TODO: Get latest version from github api 18const latest = new Map<Package, string>([
19 [Package.nukeServerSocket, "0.6.2"],
20 [Package.nukePythonStubs, "0.2.3"],
Description
Developers often add comments to code that is not complete or needs review. You probably want to fix or review the code and then remove the comments before considering the code to be production-ready. Issues are raised whenever our analyzer finds these keywords in the comments i.e., TODO, FIXME, XXX.
// TODO: do something
// FIXME: this is not a good idea
Bad Practice
// default - { "terms": ["todo", "fixme", "xxx"], "location": "start" }
function callback(err, results) {
if (err) {
console.error(err);
return;
}
// TODO
}
Recommended
// default - { "terms": ["todo", "fixme", "xxx"], "location": "start" }
function callback(err, results) {
if (err) {
console.error(err);
return;
}
// NOT READY FOR PRIME TIME
// but too bad, it is not a predefined warning term
}