smalos / nubuilder_dev

Avoid square-bracket notation when accessing properties JS-0049
Anti-pattern
Minor
9 months ago2 years old
["mm"] is better written in dot notation
1055				var l = fmt[0];
1056
1057				if (l == 'm' && FMT[nuTranslateToEnglish(v[i])] !== undefined) {
1058					d.m = FMT[nuTranslateToEnglish(v[i])]['mm'];					//-- javascript month1059				}
1060
1061				if (fmt == 'dd') {
["ddd"] is better written in dot notation
 981			s = s.replaceAll('mmm', nuTranslate(FMT[mth]['mmm']));
 982			s = s.replaceAll('mm', FMT[mth]['mm']);
 983			s = s.replaceAll('dddd', FMT[wee]['dddd']);
 984			s = s.replaceAll('ddd', FMT[wee]['ddd']); 985			s = s.replaceAll('dd', day);
 986			s = s.replaceAll('hh', hou);
 987			s = s.replaceAll('nn', min);
["dddd"] is better written in dot notation
 980			s = s.replaceAll('mmmm', nuTranslate(FMT[mth]['mmmm']));
 981			s = s.replaceAll('mmm', nuTranslate(FMT[mth]['mmm']));
 982			s = s.replaceAll('mm', FMT[mth]['mm']);
 983			s = s.replaceAll('dddd', FMT[wee]['dddd']); 984			s = s.replaceAll('ddd', FMT[wee]['ddd']);
 985			s = s.replaceAll('dd', day);
 986			s = s.replaceAll('hh', hou);
["mm"] is better written in dot notation
 979			s = s.replaceAll('yy', String(yea).substr(2));
 980			s = s.replaceAll('mmmm', nuTranslate(FMT[mth]['mmmm']));
 981			s = s.replaceAll('mmm', nuTranslate(FMT[mth]['mmm']));
 982			s = s.replaceAll('mm', FMT[mth]['mm']); 983			s = s.replaceAll('dddd', FMT[wee]['dddd']);
 984			s = s.replaceAll('ddd', FMT[wee]['ddd']);
 985			s = s.replaceAll('dd', day);
["mmm"] is better written in dot notation
 978			s = s.replaceAll('yyyy', yea);
 979			s = s.replaceAll('yy', String(yea).substr(2));
 980			s = s.replaceAll('mmmm', nuTranslate(FMT[mth]['mmmm']));
 981			s = s.replaceAll('mmm', nuTranslate(FMT[mth]['mmm'])); 982			s = s.replaceAll('mm', FMT[mth]['mm']);
 983			s = s.replaceAll('dddd', FMT[wee]['dddd']);
 984			s = s.replaceAll('ddd', FMT[wee]['ddd']);