JS-0125 @ 525da16 • smalos / nubuilder

Run summary

a year ago

868d6c1..525da16

54 s

Found the usage of undeclared variables JS-0125

Bug risk

Critical

2089 occurrences in this check

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nuuser_sfo_edit_javascript.js

 7
 8function nuTogglePasswordVisibility () {
 9  $('#new_password').nuTogglePassword()
10  $('#check_password').nuTogglePassword()11}
12
13function nuBeforeSave () {

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nuuser_sfo_edit_javascript.js

 6nuSelectAddEnglishOption('sus_language')
 7
 8function nuTogglePasswordVisibility () {
 9  $('#new_password').nuTogglePassword()10  $('#check_password').nuTogglePassword()
11}
12

'nuGetValue' is not defined

form_codes/js_codes/nuuser_sfo_edit_javascript.js

13function nuBeforeSave () {
14  const code = $('#sus_code')
15  if (code.val() === '') {
16    code.nuSetValue(nuGetValue('sus_login_name'))17  }
18
19  return true

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

267}
268
269function setConfigDatalist (cfgItem, arrDatalist) {
270 	const input = $('input').filter((i, v) => v.value == cfgItem)271  if (input.length == 1) {
272    const valueId = input.attr('id').replace('cfg_setting', 'cfg_value')
273    nuAddDatalist(valueId, arrDatalist)

'nuAddDatalist' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

270 	const input = $('input').filter((i, v) => v.value == cfgItem)
271  if (input.length == 1) {
272    const valueId = input.attr('id').replace('cfg_setting', 'cfg_value')
273    nuAddDatalist(valueId, arrDatalist)274  }
275}

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

257
258  $('.nuEdited').each(function () {
259    const rowId = this.id.replace('nuconfigsettings', '').slice(0, 3)
260    const effective = $('#nuconfigsettings' + rowId + 'cfg_effective').val()261
262    if (effective == '2' || effective == '3') { // log in again or restart browser
263      window.configEffective = effective

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

255function nuBeforeSaveConfig () {
256  window.configEffective = '1'
257
258  $('.nuEdited').each(function () {259    const rowId = this.id.replace('nuconfigsettings', '').slice(0, 3)
260    const effective = $('#nuconfigsettings' + rowId + 'cfg_effective').val()
261

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

239
240  for (let i = 0; i < sf.rows.length; i++) {
241    const el = sfName + nuPad3(i) + 'cfg_value'
242    const obj = $('#' + el)243    const val = obj.val()
244    const type = sf.rows[i][typeCol]
245

'nuPad3' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

238  const typeCol = sf.fields.indexOf('cfg_type')
239
240  for (let i = 0; i < sf.rows.length; i++) {
241    const el = sfName + nuPad3(i) + 'cfg_value'242    const obj = $('#' + el)
243    const val = obj.val()
244    const type = sf.rows[i][typeCol]

'nuSubformObject' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

234
235function sfChangeValueObjectTypes () {
236  const sfName = 'nuconfigsettings'
237  const sf = nuSubformObject(sfName)238  const typeCol = sf.fields.indexOf('cfg_type')
239
240  for (let i = 0; i < sf.rows.length; i++) {

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

199    class: el.attr('class')
200  }))
201
202  const elSelect = $('#' + i)203
204  elSelect.css({
205    top: el.cssNumber('top'),

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

193function changeObjectTypeToSelectBoolean (i) {
194  const el = $('#' + i)
195
196  el.replaceWith($('<select />').attr({197    id: el.attr('id'),
198    name: el.attr('name'),
199    class: el.attr('class')

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

191}
192
193function changeObjectTypeToSelectBoolean (i) {
194  const el = $('#' + i)195
196  el.replaceWith($('<select />').attr({
197    id: el.attr('id'),

'nuSubformAddFilter' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

187    }
188  }
189
190  nuSubformAddFilter(sfFilter)191}
192
193function changeObjectTypeToSelectBoolean (i) {

'nuTranslate' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

172}
173
174function sfAddFilters () {
175  const OPTION_ALL = '(' + nuTranslate('All') + ')'176
177  const sfFilter = {}
178  sfFilter.nuconfigsettings = {

'nuPad3' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

164  const fieldArr = nuSubformColumnArray('nuconfigsettings', 'cfg_description')
165
166  for (let i = 0; i < fieldArr.length; i++) {
167    const f = $('#nuconfigsettings' + nuPad3(i) + 'cfg_description')168    if (f.val() !== '') {
169      f.attr('title', f.val())
170    }

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

164  const fieldArr = nuSubformColumnArray('nuconfigsettings', 'cfg_description')
165
166  for (let i = 0; i < fieldArr.length; i++) {
167    const f = $('#nuconfigsettings' + nuPad3(i) + 'cfg_description')168    if (f.val() !== '') {
169      f.attr('title', f.val())
170    }

'nuSubformColumnArray' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

161}
162
163function sfSetDescriptionTitle () {
164  const fieldArr = nuSubformColumnArray('nuconfigsettings', 'cfg_description')165
166  for (let i = 0; i < fieldArr.length; i++) {
167    const f = $('#nuconfigsettings' + nuPad3(i) + 'cfg_description')

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

156  if (orgValue !== t.value) {
157    $(t).addClass('changedCgfValue')
158  } else {
159    $(t).removeClass('changedCgfValue')160  }
161}
162

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

154function onConfigValueChanged (t) {
155  const orgValue = nuBase64decode($(t).attr('data-org-value'))
156  if (orgValue !== t.value) {
157    $(t).addClass('changedCgfValue')158  } else {
159    $(t).removeClass('changedCgfValue')
160  }

'$' is not defined To fix this, add jquery in environment array of .deepsource.toml. Read more in our documentation https://deepsource.io/docs/analyzer/javascript

form_codes/js_codes/nusetup_sfo_javascript.js

  8}
  9
 10$(function () {
 11  $('#set_header').scrollTop(window.scrollTop) 12})
 13
 14$('#set_header').addClass('js')

'nuOpenAce' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

 15$('#set_style').addClass('css')
 16
 17$('.js').dblclick(function () {
 18  nuOpenAce('JavaScript', this.id) 19})
 20
 21$('.css').dblclick(function () {

'nuOpenAce' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

 19})
 20
 21$('.css').dblclick(function () {
 22  nuOpenAce('CSS', this.id) 23})
 24
 25$('#nuDeleteButton').remove()

'nuSetToolTip' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

 25$('#nuDeleteButton').remove()
 26$('#nuCloneButton').remove()
 27
 28nuSetToolTip('set_denied', nuTranslate('Disallow access to nuBuilder\'s core forms.'), true) 29
 30nuHide('set_code_snippet_lookupcode')
 31nuAttachButtonImage('icon_js', 'JS')

'nuTranslate' is not defined

form_codes/js_codes/nusetup_sfo_javascript.js

 25$('#nuDeleteButton').remove()
 26$('#nuCloneButton').remove()
 27
 28nuSetToolTip('set_denied', nuTranslate('Disallow access to nuBuilder\'s core forms.'), true) 29
 30nuHide('set_code_snippet_lookupcode')
 31nuAttachButtonImage('icon_js', 'JS')

Description

Variables that aren't defined, but accessed may throw reference errors at runtime.

NOTE: In browser applications, DeepSource recommends the use of ESModules over regular text/javascript scripts. Using variables that are injected by scripts included in an HTML file is currently not supported.

Potential ReferenceErrors may result from misspellings of variable and parameter names, or accidental implicit globals (for example, forgetting the var keyword in a for loop initializer). Any reference to an undeclared variable causes a warning, unless the variable is explicitly mentioned in a /*global ...*/ comment, or specified in the globals key in the configuration file. A common use case for these is if you intentionally use globals that are defined elsewhere (e.g. in a script sourced from HTML).

Bad Practice

const foo = someFunction(); // `someFunction` is not defined
const bar = baz + 1; // 'baz' is undeclared

smalos / nubuilder_dev

Bad Practice

Recommended