Errors detected in .deepsource.toml.
Function or method is being redefined PYL-E0102
Bug risk
Major
4 years ago
—
4 years old
method already defined line 496
699 PRODUCTION_DOMAIN='readthedocs.org',
700 PUBLIC_DOMAIN='readthedocs.io',
701 USE_SUBDOMAIN=True,
702 )703 def test_resolver_domain_https(self):
704 with override_settings(PUBLIC_DOMAIN_USES_HTTPS=True):
705 url = resolve(project=self.pip)method already defined line 802
829 @patch('readthedocs.doc_builder.backends.sphinx.BaseSphinx.move')
830 @patch('readthedocs.doc_builder.backends.sphinx.BaseSphinx.append_conf')
831 @patch('readthedocs.doc_builder.backends.sphinx.BaseSphinx.run')
832 def test_sphinx_configuration_default( 833 self, run, append_conf, move, checkout_path, tmpdir,
834 ):
835 """Should be default to find a conf.py file."""method already defined line 571
627 'http://project.dev.readthedocs.io/en/latest/my.host/path.html',
628 )
629
630 def test_redirect_sphinx_htmldir_crossdomain(self):631 """
632 Avoid redirecting to an external site unless the external site is in ``to_url``.
633 """
Description
A function, method or class is being redefined in the same scope. This would override the original definition, and doing this is strongly discouraged. Please verify that this is something that you intended to do. Redefining anything can lead to confusion, decreases code readability and may cause bugs that are difficult to diagnose. It is recommended either to refactor the function/method/class, or choose different names.
Bad practice
def calc(x, y):
return x + y
def calc(x, y):
return x * y
Recommended
def calc_sum(x, y):
return x + y
def calc_product(x, y):
return x * y