Errors detected in .deepsource.toml.
Abstract method not overridden PYL-W0223
Bug risk
Major
4 years ago
—
4 years old
Method 'update_submodules' is abstract in class 'BaseVCS' but is not overridden
9from readthedocs.vcs_support.base import BaseVCS, VCSVersion
10
11
12class Backend(BaseVCS): 13
14 """Subversion VCS backend."""
15Method 'branches' is abstract in class 'BaseVCS' but is not overridden
9from readthedocs.vcs_support.base import BaseVCS, VCSVersion
10
11
12class Backend(BaseVCS): 13
14 """Subversion VCS backend."""
15Method 'update_submodules' is abstract in class 'BaseVCS' but is not overridden
5from readthedocs.vcs_support.base import BaseVCS, VCSVersion
6
7
8class Backend(BaseVCS): 9
10 """Mercurial VCS backend."""
11Method 'branches' is abstract in class 'BaseVCS' but is not overridden
10from readthedocs.vcs_support.base import BaseVCS, VCSVersion
11
12
13class Backend(BaseVCS):14
15 """Bazaar VCS backend."""
16Method 'update_submodules' is abstract in class 'BaseVCS' but is not overridden
10from readthedocs.vcs_support.base import BaseVCS, VCSVersion
11
12
13class Backend(BaseVCS):14
15 """Bazaar VCS backend."""
16
Description
A method marked with @abstractmethod is not defined in the concrete class. This can result in unintended behavior.
It is recommended to implement all abstract methods in the derived classes.
Bad practice
from abc import ABC, abstractmethod
class Vehicle(ABC):
@abstractmethod
def start():
pass
class Car(Vehicle):
# No overridden `start` method here. Can cause unintended behavior
def stop():
self.speed = 0
Recommended
from abc import ABC, abstractmethod
class Vehicle(ABC):
@abstractmethod
def start():
pass
class Car(Vehicle):
def start():
self.speed = 3
def stop():
self.speed = 0