DeepSource
Dashboard Resources Pricing Discover Directory Log in

Run your first analysis.

Find thousands of code security and quality issues in your codebase, before they end up in production.

Start now

srl-labs / containerlab

Empty string test can be improved CRT-A0004
Anti-pattern
Major
a month ago — 3 years old
replace len(execResult.GetStdErrString()) != 0 with execResult.GetStdErrString() != ""
nodes/srl/srl.go
716		return err
717	}
718
719	if len(execResult.GetStdErrString()) != 0 {720		return fmt.Errorf("%w:%s", nodes.ErrCommandExecError, execResult.GetStdErrString())
721	}
722
replace len(execResult.GetStdErrString()) != 0 with execResult.GetStdErrString() != ""
nodes/srl/srl.go
696		return err
697	}
698
699	if len(execResult.GetStdErrString()) != 0 {700		return fmt.Errorf("%w:%s", nodes.ErrCommandExecError, execResult.GetStdErrString())
701	}
702
replace len(execResult.GetStdErrString()) != 0 with execResult.GetStdErrString() != ""
nodes/srl/srl.go
674		return err
675	}
676
677	if len(execResult.GetStdErrString()) != 0 {678		return fmt.Errorf("%w:%s", nodes.ErrCommandExecError, execResult.GetStdErrString())
679	}
680
replace len(execResult.GetStdErrString()) != 0 with execResult.GetStdErrString() != ""
nodes/srl/srl.go
364				continue
365			}
366
367			if len(execResult.GetStdErrString()) != 0 {368				log.Debugf("readyForConfigCmd stderr: %s", string(execResult.GetStdErrString()))
369				time.Sleep(retryTimer)
370				continue
replace len(execResult.GetStdErrString()) != 0 with execResult.GetStdErrString() != ""
nodes/srl/srl.go
343				continue
344			}
345
346			if len(execResult.GetStdErrString()) != 0 {347				log.Debugf("error during checking SR Linux boot status: %s", execResult.GetStdErrString())
348				time.Sleep(retryTimer)
349				continue