GO-S1027 @ 3241ba3 • srl-labs / containerlab

Run summary

2 months ago

715c7ca..3241ba3

56 s

Use net.JoinHostPort instead of fmt.Sprintf(...) GO-S1027

Security

Major

1 occurrence in this check

Use net.JoinHostPort instead of: fmt.Sprintf("%s:%d", host, t.Port)

285	}
286
287	// Start some client config
288	host = fmt.Sprintf("%s:%d", host, t.Port)289
290	t.Target = host
291

Description

Instead of manually joining hostname and port combinations, it is better to use net.JoinHostPort.

fmt.Sprintf("%s:%s", host, port)
fmt.Sprintf("%s:%d", host, port)
fmt.Sprintf("%s:%s", "", host)
fmt.Sprintf("%s:%d", "", host)

References