Simplify slice expression to sliced value itself CRT-A0016
Anti-pattern
Major
2 months ago
—
4 years old
could simplify args[:] to args
308
309 // install/run command
310 if !installed || args[0] == "npx" {
311 fmt.Printf("installing: %s\n", strings.Join(args[:], " "))312 cmd := exec.Command(args[0], args[1:]...)
313 cmd.Stdin = os.Stdin
314 cmd.Stdout = os.Stdout
Description
If a value is of type slice already, it need not be converted to slice again.
Bad practice
f(s[:]) // s is string
copy(b[:], values...) // b is []byte
Recommended
f(s)
copy(b, values...)