append possibly assigns to a wrong variable CRT-D0001
Bug risk
Minor
2 months ago
—
3 years old
append result not assigned to the same slice
365 // We should go for the primary canddiates first, but the secondary candidates are also valid
366 var candidates []*fly.Machine
367 if allowSecondaryRegion {
368 candidates = append(primaryCandidates, secondaryCandidates...)369 } else {
370 candidates = primaryCandidates
371 }
Description
The builtin function append returns the updated slice after the append operation.
This resulting slice is usually assigned back to the same variable that contained
the original slice to which new values were appended.
Bad practice
x = []int{1, 3, 5}
append(x, 7) // returns the value []int{1, 3, 5, 7}. This is usually assigned back to x
x := []int{}
y := []int{}
x = append(y, 1) // possibly wrong
Recommended
x = []int{1, 3, 5}
x = append(x, 7)
x := []int{}
y := []int{}
y = append(y, 1) // append 1 to y