Copy of large value inside loop CRT-P0006
Performance
Major
23 days ago
—
4 years old
each iteration copies 896 bytes (consider pointers or indexing)
78 }
79
80 if apps, err := apiClient.GetApps(ctx, nil); err == nil {
81 for _, app := range apps { 82 if app.Name == pgPlan.AppName {
83 attachToExisting = true
84 }each iteration copies 896 bytes (consider pointers or indexing)
508
509 var appc *fly.App
510
511 for appi, appt := range apps {512 if strings.HasPrefix(appt.Name, "flyctl-interactive-shells-") {
513 appc = &apps[appi]
514 break
Description
Avoid for loop range expressions that copy big objects for each iteration.
It is recommended to use index-based access or use pointers instead.
Bad practice
xs := make([][1024]byte, length)
for _, x := range xs {
// Loop body.
}
Recommended
xs := make([][1024]byte, length)
for i := range xs {
x := &xs[i]
// Loop body.
}