Use
(io.StringWriter).WriteString for writing strings GO-P4008
Performance
Major
19 days ago
—
a year old
f.WriteString(kubeconfig) should be preferred to the f.Write([]byte(kubeconfig))
83
84 metadata := resp.AddOn.Metadata.(map[string]interface{})
85 kubeconfig := metadata["kubeconfig"].(string)
86 if _, err := f.Write([]byte(kubeconfig)); err != nil {87 return fmt.Errorf("failed to write kubeconfig to file %s, error: %w", outFilename, err)
88 }
89f.WriteString(kubeconfig) should be preferred to the f.Write([]byte(kubeconfig))
54 }
55 defer f.Close()
56
57 _, err = f.Write([]byte(kubeconfig))58 if err != nil {
59 return fmt.Errorf("failed to write kubeconfig to file %s, error: %w", outFilename, err)
60 }f.WriteString(filePrepender(filename)) should be preferred to the io.WriteString(f, filePrepender(filename))
176 }
177 defer f.Close()
178
179 if _, err := io.WriteString(f, filePrepender(filename)); err != nil {180 return err
181 }
182 if err := GenMarkdownCustom(cmd, f, linkHandler); err != nil {
Description
It is recommended to use (io.StringWriter).WriteString instead of
(io.StringWriter).Write or io.WriteString for writing strings as it decreases
the number of allocations required, therefore improving performance.
Bad practice
package main
import (
"io"
)
func foo(w io.StringWriter) {
w.Write([]byte("foo"))
io.WriteString(w, "bar")
}
Recommended
package main
import (
"io"
)
func foo(w io.StringWriter) {
w.WriteString("foo")
w.WriteString("bar")
}