Use
%q to quote a string in fmt.Sprintf format specifiers GO-R4002
Anti-pattern
Minor
2 months ago
—
a year old
use %q instead of "%s" for quoted strings
941 case len(groupConfig.AllServices()) > 0:
942 description = fmt.Sprintf("2 \"%s\" machines", name)
943 default:
944 description = fmt.Sprintf("1 \"%s\" machine and 1 standby machine for it", name) 945 }
946 fmt.Fprintf(md.io.Out, " %s create %s\n", bullet, description)
947 }use %q instead of "%s" for quoted strings
939 case !md.increasedAvailability || len(groupConfig.Mounts) > 0:
940 description = fmt.Sprintf("1 \"%s\" machine", name)
941 case len(groupConfig.AllServices()) > 0:
942 description = fmt.Sprintf("2 \"%s\" machines", name) 943 default:
944 description = fmt.Sprintf("1 \"%s\" machine and 1 standby machine for it", name)
945 }use %q instead of "%s" for quoted strings
937 case err != nil:
938 continue
939 case !md.increasedAvailability || len(groupConfig.Mounts) > 0:
940 description = fmt.Sprintf("1 \"%s\" machine", name) 941 case len(groupConfig.AllServices()) > 0:
942 description = fmt.Sprintf("2 \"%s\" machines", name)
943 default:use %q instead of "%s" for quoted strings
272 }
273 }
274 if cfg.Build.Builtin != "" {
275 strategies = append(strategies, fmt.Sprintf("the \"%s\" builtin image", cfg.Build.Builtin))276 }
277
278 return strategiesuse %q instead of "%s" for quoted strings
266 }
267 if cfg.Build.Dockerfile != "" || cfg.Build.DockerBuildTarget != "" {
268 if cfg.Build.Dockerfile != "" {
269 strategies = append(strategies, fmt.Sprintf("the \"%s\" dockerfile", cfg.Build.Dockerfile))270 } else {
271 strategies = append(strategies, "a dockerfile")
272 }
Description
%q is same as "%s".
Bad practice
str := fmt.Sprintf("str: "%s"", "Hello World")
// str => str: "Hello World"
Recommended
str := fmt.Sprintf("str: %q", "Hello World")
// str => str: "Hello World"