MinVersion is missing from this TLS configuration GO-S1020MinVersion is missing from this TLS configuration: tls.Config471 "Authorization": "Basic " + basicAuth(appName, config.Tokens(ctx).Docker()),
472 }),
473 dockerclient.WithDialContext(func(ctx context.Context, network, addr string) (net.Conn, error) {
474 return tls.Dial("tcp", parsedHostUrl.Host+":443", &tls.Config{})475 }),
476 }
477MinVersion is missing from this TLS configuration: tls.Config233 client := &http.Client{
234 Transport: &http.Transport{
235 DialContext: func(ctx context.Context, network, addr string) (net.Conn, error) {
236 return tls.Dial("tcp", fmt.Sprintf("%s.fly.dev:443", app.Name), &tls.Config{})237 },
238 },
239 }
Description
MinVersion is missing from this TLS configuration. As the default value is
TLS 1.0, which is considered insecure, it is recommended to explicitly set the
MinVersion to a secure version of TLS, such as VersionTLS13.
Bad practice
client := &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{
KeyLogWriter: w,
Rand: rand{},
InsecureSkipVerify: true,
},
},
}
Recommended
client := &http.Client{
Transport: &http.Transport{
TLSClientConfig: &tls.Config{
KeyLogWriter: w,
MinVersion: tls.VersionTLS13, // min version set
Rand: rand{},
InsecureSkipVerify: true,
},
},
}