Poor file permissions used when creating a directory GSC-G301
Expect directory permissions to be 0750 or less
28 for _, filename := range filenames {
29 content := []byte(filename)
30 filename = filepath.Join(tempDir, filename)
31 err = os.MkdirAll(filepath.Dir(filename), 0o777) 32 if err != nil {
33 return
34 }Expect directory permissions to be 0750 or less
40 }
41
42 // TODO: this should probably be 0755
43 return os.MkdirAll(pathname, 0o777)44}
Description
Excessive permissions granted when creating a directory. This warning is
triggered whenever permission greater than 0750 is given.
In general, all security rules follow the principle of least privilege, except when the created directory needs to be accessed by anyone other than the user creating it.
Bad practice
package main
import (
"fmt"
"os"
)
func main() {
err := os.Mkdir("/tmp/mydir", 0777)
if err != nil {
fmt.Println("Error when creating a directory!")
return
}
}
Recommended
package main
import (
"fmt"
"os"
)
func main() {
err := os.Mkdir("/tmp/mydir", 0600)
if err != nil {
fmt.Println("Error when creating a directory!")
return
}
}