Exit inside non-main function RVV-A0003
Anti-pattern
Major
a month ago
—
3 years old
calls to log.Fatal only in main() or init() functions
101 contents := fmt.Sprintf("app = \"%s\"\n", appName)
102 err := os.WriteFile(flyToml, []byte(contents), 0644)
103 if err != nil {
104 log.Fatal(err)105 }
106
107 // inform caller of the presence of this filecalls to log.Fatal only in main() or init() functions
254 contents := fmt.Sprintf("app = \"%s\"\n", appName)
255 err := os.WriteFile(flyToml, []byte(contents), 0644)
256 if err != nil {
257 log.Fatal(err)258 }
259
260 // inform caller of the presence of this filecalls to log.Fatal only in main() or init() functions
57
58 signer, err := ssh.NewCertSigner(cert, keySigner)
59 if err != nil {
60 log.Fatal(err) 61 }
62
63 tcpConn, err := c.Dial(ctx, "tcp", c.Addr)calls to log.Panicf only in main() or init() functions
313
314 raw, err := msg.Marshal(nil)
315 if err != nil {
316 log.Panicf("marshal icmp: %s", err)317 }
318
319 return raw
Description
Packages exposing functions that can stop program execution by exiting are hard to reuse. Program exits in functions other than main() or init() are not encouraged.
Bad practice
func nonMainFunc() {
safelyExit := true // somehow arrive at this value
if safelyExit {
os.Exit(0)
}
}
func main() {
nonMainFunc()
}
Recommended
func nonMainFunc() bool {
safelyExit := true // somehow arrive at this value
}
func main() {
safelyExit := nonMainFunc()
if safelyExit {
os.Exit(0)
}
}