Functions prefixed with
Get should return a value RVV-A0006
Anti-pattern
Major
a month ago
—
2 years old
function 'getDir' seems to be a getter but it does not return any result
295 return nil
296}
297
298func (sc *sftpContext) getDir(rpath string, args []string) {299 lpath := path.Base(rpath) + ".zip"
300
301 if len(args) > 2 {
Description
Typically, functions with names prefixed with Get are supposed to return a value.
Bad practice
func GetData(n int) {
fmt.Println(10 - n)
}
Recommended
func GetData(n int) int {
fmt.Println(10 - n)
return 10 - n
}