Redundant else-blocks can be eliminated RVV-A0009
Anti-pattern
Major
a month ago
—
2 years old
if block ends with a break statement, so drop this else and outdent its block
563 if err == readline.ErrInterrupt {
564 if len(line) == 0 {
565 break
566 } else {567 continue
568 }
569 } else if err == io.EOF {
Description
To ensure as little nesting as possible (to improve code readability), the
else blocks that can be eliminated should be removed. For example, if the if
block contains a return statement, the else block can be omitted entirely.
Bad practice
for {
if ok := f(); ok {
a := 1
continue
} else {
return "it's NOT okay!"
}
}
Recommended
for {
if ok := f(); ok {
a := 1
continue
}
return "it's NOT okay!"
}