Redefinition of builtin RVV-B0009
Bug risk
Major
a month ago
—
2 years old
redefinition of the built-in type bool
180 fmt.Fprintln(io.ErrOut)
181 }
182
183 if bool, err := cmd.Flags().GetBool(flagnames.Debug); err == nil && bool {184 fmt.Fprintf(io.ErrOut, "Stacktrace:\n%s\n", debug.Stack())
185 }
186}redefinition of the built-in function close
81 }
82
83 out = io.MultiWriter(os.Stdout, f)
84 close = func() { 85 _ = f.Sync()
86 _ = f.Close()
87 }
Description
Constant names like false, true, nil and function names like append,
make, and basic type names like bool, and byte are not reserved keywords
of the language making them eligible for redefinition. It is not recommended to
redefine these builtins (or keywords) that can lead to bugs that are very
difficult to detect.
Bad practice
nil := true
Recommended
nilVal := true