Unused method receiver RVV-B0013
Bug risk
Major
2 days ago
—
3 years old
Method receiver 'bg' is not referenced in method's body, consider removing it
265 }
266}
267
268func (bg *blueGreen) changeDetected(a, b map[string]string) bool {269 for key := range a {
270 if a[key] != b[key] {
271 return trueMethod receiver 'lm' is not referenced in method's body, consider removing it
225 }
226}
227
228func (lm *leasableMachine) isConstantlyRestarting(machine *fly.Machine) bool {229 var ev *fly.MachineEvent
230
231 for _, mev := range machine.Events {Method receiver 'md' is not referenced in method's body, consider removing it
731 return nil
732}
733
734func (md *machineDeployment) updateMachineInPlace(ctx context.Context, e *machineUpdateEntry) error { 735 lm := e.leasableMachine
736 return lm.Update(ctx, *e.launchInput)
737}Method receiver 'l' is not referenced in method's body, consider removing it
281 return nil
282}
283
284func (l *Launcher) getPostgresConfig(config *CreateClusterInput) *fly.MachineConfig {285 machineConfig := fly.MachineConfig{}
286
287 // Set envMethod receiver 'e' is not referenced in method's body, consider removing it
70 desiredState string
71}
72
73func (e WaitTimeoutErr) Error() string {74 return "timeout reached waiting for machine's state to change"
75}
76
Description
Methods with unused receivers can be a symptom of unfinished refactoring or a bug. To keep the same method signature, omit the receiver name or '_' as it is unused.
Bad practice
func (f *Unix) Name() string {
return "unix"
}
func (_ *Unix) Name() string {
return "unix"
}
Recommended
func (*Unix) Name() string {
return "unix"
}