TLS MinVersion too low.
235 client := &http.Client{
236 Transport: &http.Transport{
237 DialContext: func(ctx context.Context, network, addr string) (net.Conn, error) {
238 return tls.Dial("tcp", fmt.Sprintf("%s.fly.dev:443", builderApp.Name), &tls.Config{})239 },
240 },
241 }
Description
Insecure configuration of TLS connection settings. Refer to the occurrence to understand the exact misconfiguration.
The following configurations are flagged by our systems:
InsecureSkipVerifyset totruein TLS config -- https://golang.org/pkg/crypto/tls/#ConfigMinVersionorMaxVersiontoo low.- Bad cipher suite used.
Refer to this compatibility document before making changes -- https://wiki.mozilla.org/Security/ServerSideTLS#Modern_compatibility
Bad practice
// Insecure minimum version
package main
import "crypto/tls"
func main() {
config := &tls.Config{MinVersion: 0}
...
}
Recommended
package main
import "crypto/tls"
func saferTLSConfig() {
config := &tls.Config{}
config.MinVersion = tls.VersionTLS12
config.MaxVersion = tls.VersionTLS13
// (or)
config.MaxVersion = 0 // GOOD: Setting MaxVersion to 0 means that the highest version available in the package will be used.
}