Found complex boolean return JS-W1041
Anti-pattern
Major
6 months ago
—
7 months old
Boolean return can be simplified
12 return false;
13 }
14
15 if (state === State.UPLOAD) {16 return true;17 }18
19 return false;
20}Boolean return can be simplified
8 return false;
9 }
10
11 if (state === State.COMPLETE || state === State.PROCESSING) {12 return true;13 }14
15 return false;
16}
Description
The following pattern:
if (condition) {
return true
}
return false
can be refactored to:
return condition
When condition is not a boolean value,
it can be cast into one using the Boolean constructor.
Bad Practice
function isEven(num: number) {
if (num % 2 === 0) return true
return false
}
async function userExists(name: string) {
if (await db.getUser(name)) return true
return false
}
Recommended
function isEven(num: number) {
return num % 2 === 0
}
async function userExists(name: string) {
return Boolean(await db.getUser(name))
}